Kh agent/vibe dev/pwa instructions #70

bromiesTM · 2025-08-11T14:42:51Z

No description provided.

Copilot

Pull Request Overview

This PR adds Progressive Web App (PWA) installation functionality, allowing users to install IONOS GPT as an app on their devices. The implementation includes platform-specific detection, installation prompts, and user interface components.

Adds PWA detection and installation utilities with platform-specific logic for iOS/Safari vs other browsers
Implements PWA install dialog with step-by-step instructions for iOS users
Integrates PWA notifications into the existing notification system with appropriate event handling

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
src/lib/i18n/locales/en-US/ionos.json	Adds English translations for PWA installation UI text
src/lib/i18n/locales/de-DE/ionos.json	Adds German translations for PWA installation UI text
src/lib/IONOS/services/pwa.ts	Core PWA service with platform detection and installation logic
src/lib/IONOS/components/notifications/PWAInstallDialog.svelte	Dialog component for PWA installation with iOS-specific instructions
src/lib/IONOS/components/notifications/NotificationManager.svelte	Integrates PWA notifications into notification system
src/lib/IONOS/components/notifications/NotificationBanner.svelte	Adds PWA install handling to notification banner
src/lib/IONOS/components/icons/Touch.svelte	Touch icon for PWA UI
src/lib/IONOS/components/icons/Share.svelte	Share icon for iOS installation instructions
src/lib/IONOS/components/common/Dialog.svelte	Adds external close button functionality for PWA dialog

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

src/lib/IONOS/services/pwa.ts

src/lib/IONOS/components/notifications/NotificationManager.svelte

src/lib/IONOS/components/common/Dialog.svelte

thlehmann-ionos

Let's discuss.

src/lib/IONOS/components/notifications/NotificationManager.svelte

src/lib/IONOS/services/pwa.ts

src/lib/IONOS/components/notifications/NotificationManager.svelte

src/lib/IONOS/services/pwa.ts

thlehmann-ionos · 2025-09-19T15:16:19Z

src/lib/IONOS/services/pwa.ts

+/**
+ * Checks if we should show the PWA install prompt
+ */
+export function shouldShowPWAPrompt(deferredPrompt: BeforeInstallPromptEvent | null = null): boolean {


The fact that it can be called with an optional event leads to confusion in some places where this function is called as at the calling point it does not work as expected.

thlehmann-ionos · 2025-09-19T15:17:56Z

src/lib/IONOS/services/pwa.ts

+
+export interface BeforeInstallPromptEvent extends Event {
+	readonly platforms: string[];
+	readonly userChoice: Promise<{


This should be its own type. In one place this property was cast to any. Its type could and should be declared in that place (which also gives a linter warning on any).

Copilot

Pull Request Overview

Copilot reviewed 14 out of 15 changed files in this pull request and generated 3 comments.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-10-01T08:00:09Z

src/lib/IONOS/components/common/Dialog.svelte

+		else {
+		}


Empty else block should be removed as it serves no purpose and reduces code clarity.

Suggested change

else {

}

src/lib/IONOS/components/common/Dialog.svelte

src/routes/styleguide/+layout.svelte

Signed-off-by: Kai Henseler <[email protected]>

* Added external close-X below the content element * Removed overflow-hidden to allow new close-X to leave the container Notes: * Works for the privacy links banner * It should have a prop to enable this explicitly * Maybe it's better to have a special dialog fo such use cases * Maybe it should hide the inner button on mobile breakpoint and show the other one instead or maybe the inner one can be repurposed just by conditions Refs: PRODAI-380

To allow reuse in another place. Refs: PRODAI-380

Signed-off-by: Kai Henseler <[email protected]>

bromiesTM force-pushed the kh-agent/vibe-dev/pwa-instructions branch from 8f2778e to 366487a Compare August 11, 2025 14:44

bromiesTM force-pushed the kh-agent/vibe-dev/pwa-instructions branch from 366487a to 0d59dd2 Compare September 10, 2025 06:51

bromiesTM requested a review from Copilot September 10, 2025 06:55

This comment was marked as outdated.

Sign in to view

bromiesTM requested a review from Copilot September 10, 2025 07:50

This comment was marked as outdated.

Sign in to view

bromiesTM force-pushed the kh-agent/vibe-dev/pwa-instructions branch from 0d59dd2 to 4adef4e Compare September 10, 2025 07:54

bromiesTM requested a review from Copilot September 10, 2025 07:54

Copilot AI reviewed Sep 10, 2025

View reviewed changes

thlehmann-ionos force-pushed the ionos-dev branch from 27f58bc to 4e32818 Compare September 10, 2025 08:18

bromiesTM force-pushed the kh-agent/vibe-dev/pwa-instructions branch from 4adef4e to ffc7117 Compare September 16, 2025 07:39

thlehmann-ionos reviewed Sep 16, 2025

View reviewed changes

src/lib/IONOS/components/common/Dialog.svelte Outdated Show resolved Hide resolved

thlehmann-ionos requested changes Sep 19, 2025

View reviewed changes

bromiesTM force-pushed the kh-agent/vibe-dev/pwa-instructions branch from 4ad0c63 to d6012e9 Compare September 24, 2025 07:51

bromiesTM requested a review from Copilot October 1, 2025 07:59

bromiesTM marked this pull request as ready for review October 1, 2025 07:59

Copilot AI reviewed Oct 1, 2025

View reviewed changes

bromiesTM force-pushed the kh-agent/vibe-dev/pwa-instructions branch from c59b275 to 24be6ba Compare October 1, 2025 08:05

bromiesTM and others added 12 commits October 1, 2025 10:05

c/feat(PWA): add pwa banner & install instructions dialog

c1189a8

Signed-off-by: Kai Henseler <[email protected]>

c/chore: add styleguide test pages

0772066

Signed-off-by: Kai Henseler <[email protected]>

refac(Dialog): refactor close action to named function

3289991

To allow reuse in another place. Refs: PRODAI-380

c/chore(translations): add missing translation key

fe2cedf

Signed-off-by: Kai Henseler <[email protected]>

c/fix(pwa): dont dismiss on dialog close

6e99610

Signed-off-by: Kai Henseler <[email protected]>

c/fix(PwaDialog): fix external close button location & backdrop

d8c2a76

Signed-off-by: Kai Henseler <[email protected]>

c/refactor(pwa): remove comments without value

c1e2111

Signed-off-by: Kai Henseler <[email protected]>

style(styleguide): make mobile compatible

a64c455

Signed-off-by: Kai Henseler <[email protected]>

c/feat: move pwa deferredPrompt to store

349a623

Signed-off-by: Kai Henseler <[email protected]>

style(pwa dialog): improve spacing

084a5e8

Signed-off-by: Kai Henseler <[email protected]>

refactor(pwa): handle pwa install in manager

de52e0f

Signed-off-by: Kai Henseler <[email protected]>

bromiesTM force-pushed the kh-agent/vibe-dev/pwa-instructions branch from 24be6ba to de52e0f Compare October 1, 2025 08:05

bromiesTM merged commit 9807d4b into ionos-dev Oct 1, 2025
1 check passed

Kh agent/vibe dev/pwa instructions #70

Kh agent/vibe dev/pwa instructions #70

Uh oh!

Conversation

bromiesTM commented Aug 11, 2025

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

thlehmann-ionos left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

thlehmann-ionos Sep 19, 2025

Choose a reason for hiding this comment

Uh oh!

thlehmann-ionos Sep 19, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Copilot AI Oct 1, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants